Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dispatch to update API cache in background if cache was already present #1657

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added dispatch to update API cache in background if cache was already present #1657

wants to merge 1 commit into from

Conversation

ebkr
Copy link
Owner

@ebkr ebkr commented Mar 8, 2025

No description provided.

@ebkr ebkr requested a review from anttimaki March 8, 2025 12:45
anttimaki
anttimaki approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on very quick testing this seems to work. Personally I would perhaps add a comment or something that the bit odd placing and missing await are intentional as this is supposed to happen on the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttimaki anttimaki anttimaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebkr @anttimaki